Pull request fix issue #73 #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Amazing! Thanks a lot. Any chance you could change the double quotes to single ones. Just so it's consistent. Thanks! |
|
Yes I can do that |
…y 'value' on number '0' #73 - refactor
|
I actually changed it to used the existing isObject function - what I should have done, had I seen it in the first place. |
|
@jamespfarrell Nice one, thanks a lot! 🎹 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes this issue , which I found by way of this issue
I can re-build and create another pull request for the sympathetic synth once this one has gone through.
Please let me know if you think there is a better way to fix this of course, and thanks for all your hard work! :)
James